Skip to content

Improve accuracy of colcon-test-result (backport #172) - #183

Merged
scpeters merged 1 commit into
gz-tools2from
mergify/bp/gz-tools2/pr-172
Aug 17, 2026
Merged

Improve accuracy of colcon-test-result (backport #172)#183
scpeters merged 1 commit into
gz-tools2from
mergify/bp/gz-tools2/pr-172

Conversation

@mergify

@mergify mergify Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

🦟 Bug fix

Helps with gazebosim/sdformat#1648

Summary

While experimenting with action-ros-ci in gazebosim/sdformat#1648, I noticed that colcon test-result incorrectly identifies a failed test in a gz-tools build folder even when tests haven't been run due to the .xml suffix of the intermediate ${TEST_NAME}_fail.xml file (also known as UNIT_gz_TEST_fail.xml).

Adding a suffix to the intermediate junit xml files prevents colcon test-result from reading them as real test results.

To test:

  1. create a colcon workspace containing gz-tools
  2. colcon build
  3. colcon test-result should not show a failure
  4. colcon test && colcon test-result still should not show the spurious failure

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.


This is an automatic backport of pull request #172 done by [Mergify](https://mergify.com).

Add suffix to intermediate junit xml files to prevent
colcon test-result from reading them as real test
results.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit 84d2141)
@mergify
mergify Bot requested a review from caguero as a code owner August 17, 2026 18:52
@github-actions github-actions Bot added 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Aug 17, 2026
@mergify mergify Bot mentioned this pull request Aug 17, 2026
11 tasks
@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Aug 17, 2026
@scpeters
scpeters merged commit cc87c9c into gz-tools2 Aug 17, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Aug 17, 2026
@scpeters
scpeters deleted the mergify/bp/gz-tools2/pr-172 branch August 17, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants